feat(server): admin port and interface #709

boazsade · 2023-01-19T11:48:41Z

Signed-off-by: Boaz Sade [email protected]

Fix issue #668
This will:

change the flag http_admin_console --> primary_port_http_enabled.
Add flag admin_port that when set, enable connecting with HTTP/RESP to this port.
Add flag admin_bind that when set (together with admin_port), enable connection with HTTP/RESP on this address/port.
By default these two new flags are disabled.
Note that if the connection is from admin port while admin port is enabled, it will allow HTTP connection to this port/address only. Trying to connect to the console from the "normal" port will not for HTTP connection

src/server/dfly_main.cc

src/facade/dragonfly_connection.cc

Signed-off-by: Boaz Sade <[email protected]>

romange reviewed Jan 19, 2023

View reviewed changes

src/server/dfly_main.cc Outdated Show resolved Hide resolved

romange reviewed Jan 19, 2023

View reviewed changes

src/facade/dragonfly_connection.cc Show resolved Hide resolved

boazsade force-pushed the admin-panel-diff-ports branch from f184589 to 69ac390 Compare January 19, 2023 15:17

romange previously approved these changes Jan 19, 2023

View reviewed changes

feat(server): admin port and interface

50b0a2c

Signed-off-by: Boaz Sade <[email protected]>

boazsade dismissed romange’s stale review via 50b0a2c January 19, 2023 16:42

boazsade force-pushed the admin-panel-diff-ports branch from 69ac390 to 50b0a2c Compare January 19, 2023 16:42

feat(server): admin port and address for console support

cdd6d4d

Signed-off-by: Boaz Sade <[email protected]>

boazsade requested a review from romange January 19, 2023 16:55

romange approved these changes Jan 19, 2023

View reviewed changes

romange merged commit 49e53d5 into dragonflydb:main Jan 19, 2023

Provide feedback