Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): build debian package for arm64 arch #719

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

boazsade
Copy link
Contributor

Signed-off-by: Boaz Sade [email protected]

This would add support for building the debian package for ARM64 based arch.

  • The git action file will run the script that generate a package for ARM as well as for x86.
  • The build script is now accepting new arg of the arch type.
  • The build of the ARM package can only be run inside environment that is itself ARM64.

Copy link
Collaborator

@romange romange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but please make the architecture deduction automatic based on uname

@boazsade boazsade force-pushed the debian-install-arm64 branch 2 times, most recently from b0669b5 to 93afcb2 Compare January 23, 2023 16:30
@boazsade boazsade force-pushed the debian-install-arm64 branch from 93afcb2 to 701acae Compare January 24, 2023 09:16
@romange romange merged commit 3360ff1 into dragonflydb:main Jan 24, 2023
boazsade added a commit to boazsade/dragonfly that referenced this pull request Jan 31, 2023
boazsade added a commit to boazsade/dragonfly that referenced this pull request Feb 1, 2023
* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* gggggg

* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is foo message

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): testing build

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): testing build

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(action): build debian package for arm64 arch (dragonflydb#719)

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): disable the test build

Signed-off-by: Boaz Sade <[email protected]>

---------

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this pull request Feb 1, 2023
* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* gggggg

* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is foo message

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): testing build

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): testing build

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(actions): add support for debian packaging

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(test): testing arm64 build

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): this is a test

Signed-off-by: Boaz Sade <[email protected]>

* feat(action): build debian package for arm64 arch (dragonflydb#719)

Signed-off-by: Boaz Sade <[email protected]>

* feat(foo): disable the test build

Signed-off-by: Boaz Sade <[email protected]>

---------

Signed-off-by: Boaz Sade <[email protected]>
boazsade added a commit to boazsade/dragonfly that referenced this pull request Feb 1, 2023
romange pushed a commit that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants