fix(lua): Fix a deadlock happenning when calling a lua script #726
+34
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scenario is described in a unit test that reproduces the issue with high chance. Also added dragonfly_test in repeat=100 mode to CI. Signed-off-by: Roman Gershman <[email protected]>
romange
force-pushed
the
FixLuaDeadlock
branch
from
470f81e to
be70aaf
Compare
dranikpg
approved these changes
Jan 25, 2023
ashotland
reviewed
Jan 26, 2023
|
on my machine it takes 10s to run this test.
Lets reduce it to gtest_repeat=10.
…On Fri, Jan 27, 2023 at 12:03 AM ashotland ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/ci.yml
<#726 (comment)>
:
> @@ -78,7 +78,7 @@ jobs:
echo Run ctest -V -L DFLY
#GLOG_logtostderr=1 GLOG_vmodule=transaction=1,engine_shard_set=1
GLOG_logtostderr=1 GLOG_vmodule=rdb_load=1,rdb_save=1,snapshot=1 ctest -V -L DFLY
- ./dragonfly_test --mem_defrag_threshold=0.05 # trying to catch issue with defrag
+ ./dragonfly_test --gtest_repeat=100
@romange <https://github.com/romange> --gtest_repeat=100 it seems 100
repetitions timesout the ci-tests (takes over 30 mins), is it needed?
—
Reply to this email directly, view it on GitHub
<#726 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCAYMXG6CMPVZN25K6LWULYDBANCNFSM6AAAAAAUF67SCU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario is described in a unit test that reproduces the issue with high chance. Also added dragonfly_test in repeat=100 mode to CI.
Signed-off-by: Roman Gershman [email protected]