feat(server): add latency statistics for lua script calls #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
force-pushed
the
MeasureEvalLatencyt
branch
from
c86a766 to
3fbd436
Compare
dranikpg
previously approved these changes
Feb 5, 2023
|
can you detail what I missed? :)
…On Sun, Feb 5, 2023 at 5:37 PM Vladislav ***@***.***> wrote:
***@***.**** approved this pull request.
You missed a few moves here and there when passing the scripts around 👀
, but I assume its not important at all
—
Reply to this email directly, view it on GitHub
<#758 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCBEUGIM6KFNKCD6IBDWV7CKLANCNFSM6AAAAAAURXEAK4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dranikpg
reviewed
Feb 5, 2023
src/server/dflycmd.cc
Outdated
Comment on lines
457
to
462
| auto scripts = sf_->script_mgr()->GetLuaScripts(); | ||
| ec = saver->SaveHeader(scripts); | ||
| StringVec script_bodies; | ||
| for (const auto& script : scripts) { | ||
| script_bodies.push_back(script.second); | ||
| } | ||
| ec = saver->SaveHeader(script_bodies); |
There was a problem hiding this comment.
You get the scripts by value here and proceed to build a new container by copying the scripts itself
src/server/server_family.cc
Outdated
Comment on lines
880
to
885
| auto scripts = script_mgr_->GetLuaScripts(); | ||
| StringVec script_bodies; | ||
| for (const auto& script : scripts) { | ||
| script_bodies.push_back(script.second); | ||
| } | ||
| return script_bodies; |
Also provide new subcommands "script list" and "script latency" Fixes #754 Signed-off-by: Roman Gershman <[email protected]>
romange
force-pushed
the
MeasureEvalLatencyt
branch
from
3fbd436 to
3635858
Compare
dranikpg
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provide new subcommands "script list" and "script latency" Fixes #754
Signed-off-by: Roman Gershman [email protected]