bug(server): fix deadlock in BufferedStreamerBase notify all producers #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adi_holden <[email protected]>
|
Can you provide some context, explanation as to how the deadlock happens? |
dranikpg
approved these changes
Feb 5, 2023
|
The big difference is that we now have multiple producers: regular replication and expiration. I didn't take this into account when writing the code So if both the expire and regular blocked due to backpressue, and only the expire is woken up, then the transaction keeps stuck forever until the next wakeup with luck, which can be never, in case no more items expire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.