Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(server): adding unit tests for reply builder #764

Merged
merged 1 commit into from
Feb 12, 2023
Merged

test(server): adding unit tests for reply builder #764

merged 1 commit into from
Feb 12, 2023

Conversation

boazsade
Copy link
Contributor

@boazsade boazsade commented Feb 8, 2023

Fixes issue #180
This do unit test converge for reply_builder RESP.

  • Verify that the resulting output bytes are in correct format based on the protocol spec.
  • Verify that the messages can be successfully parsed by the REDIS parser.
    Signed-off-by: Boaz Sade [email protected]

@boazsade boazsade force-pushed the test-reply-builder branch 2 times, most recently from 79258fb to 2e6968b Compare February 8, 2023 12:08
@romange romange requested review from adiholden and romange and removed request for romange February 8, 2023 12:23
@boazsade boazsade force-pushed the test-reply-builder branch 2 times, most recently from 95d3302 to 2d4a430 Compare February 8, 2023 13:43
@boazsade boazsade force-pushed the test-reply-builder branch 2 times, most recently from fb4a605 to 3334895 Compare February 12, 2023 11:02
@boazsade boazsade merged commit b62a590 into dragonflydb:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange left review comments

@adiholden adiholden adiholden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boazsade @romange @adiholden