bug(replica): execute expire within multi command only if its belong … #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the same dbid Signed-off-by: adi_holden <[email protected]>
Signed-off-by: adi_holden <[email protected]>
dranikpg
reviewed
Feb 8, 2023
Comment on lines
+591
to
+601
| for i in range(8): | ||
| is_multi = i % 2 | ||
| c_master_db = aioredis.Redis(port=master.port, db=i) | ||
| pipe = c_master_db.pipeline(transaction=is_multi) | ||
| # Set simple keys n_keys..n_keys*2 on master | ||
| start_key = n_keys*(i+1) | ||
| end_key = start_key + n_keys | ||
| batch_fill_data(client=pipe, gen=gen_test_data( | ||
| end_key, start_key), batch_size=20) | ||
|
|
||
| await pipe.execute() |
There was a problem hiding this comment.
you could run this in parallel with asyncio crate_task, I assume this would be more reliable
There was a problem hiding this comment.
but actually I do not want this to be in parallel to make sure I add entries while other entries are expired, if I will do it in parallel it might be that I finished adding the entries before heartbeat expired the above entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.