EVAL multi modes + non atomic modes #818
Conversation
dranikpg
commented
Feb 18, 2023
•
dranikpg
commented
- add multi modes to eval
- add non atomic modes
- allow undeclared kets with global & non atomic modes
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
| } else if (multi_mode == Transaction::NON_ATOMIC) { | ||
| scheduled = true; | ||
| cntx->transaction->StartMultiNonAtomic(); | ||
| }; |
There was a problem hiding this comment.
can it be that we have "scheduled == false" ?
There was a problem hiding this comment.
I don't like this part either.
A non-atomic multi transaction is neither a "classic" multi transaction neither a regular transaction because its re-initialized with the multi mechanism.
I had to decide whether to make it transparently multi and behave like one or make it explicitly non multi. I went with the first approach. It behaves exactly like a multi for the outside users.
Internally, there is IsMulti and IsRunningMulti where this distinguishment happens. What do you think?
There was a problem hiding this comment.
Maybe it should be renamed to smth like IsAtomicMulti?
There was a problem hiding this comment.
I was not aware of this distinction and I thought there is only IsRunningMulti.
so yes, IsAtomicMulti is better.
|
I'm not sure we need extensive tests. What are we testing for specifically? We can always test with MULTI/EXEC transactions instead |
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
update-multi-2
branch
from
af21149 to
ab8f8cd
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
| LOG(ERROR) << "Internal error, system probably unstable " << e.what(); | ||
| // Collect stats for all regular transactions and all multi transactions from scripts, except EVAL | ||
| // itself. EXEC does not use DispatchCommand for dispatching. | ||
| bool collect_stats = |
There was a problem hiding this comment.
I do not understand the second part of condition.
if exec does not use DispatchCommand, then when (!dfly_cntx->transaction->IsMulti() || under_script) is false?
There was a problem hiding this comment.
I wrote it in the comments: except EVAL itself
