fix(server): fix JSON.MGET implementation (#849) #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iko1
force-pushed
the
fix/json-mget
branch
2 times, most recently
from
a2358bd to
897ace1
Compare
romange
reviewed
Feb 27, 2023
src/server/json_family.cc
Outdated
| OpResult<JsonType*> result = GetJson(op_args, it); | ||
| if (!result) { | ||
| vec.emplace_back(); | ||
| vector<OptString> OpMGet(JsonExpression& expression, const Transaction* t, EngineShard* shard) { |
There was a problem hiding this comment.
why expression is passed by mutable reference, @iko1 ?
the reason I am asking is if it's been mutated then there is a potential data-race since OpMGet is called in parallel from multiple threads.
There was a problem hiding this comment.
so either lets change it to const ref or pass it by value
romange
reviewed
Feb 27, 2023
src/server/json_family.cc
Outdated
| if (!it) { | ||
| (*cntx)->SendNull(); | ||
| } else { | ||
| (*cntx)->SendSimpleString(*it); |
There was a problem hiding this comment.
I think it's better to use SendBulkString here
iko1
force-pushed
the
fix/json-mget
branch
3 times, most recently
from
1f59af3 to
4063db1
Compare
romange
reviewed
Mar 1, 2023
src/server/json_family.cc
Outdated
| OpResult<JsonType*> result = GetJson(op_args, it); | ||
| if (!result) { | ||
| vec.emplace_back(); | ||
| vector<OptString> OpMGet(JsonExpression&& expression, const Transaction* t, EngineShard* shard) { |
There was a problem hiding this comment.
i do not see a good reason to pass JsonExpression&& over JsonExpression
romange
reviewed
Mar 1, 2023
src/server/json_family.cc
Outdated
| vector<OptString> OpMGet(JsonExpression&& expression, const Transaction* t, EngineShard* shard) { | ||
| auto args = t->GetShardArgs(shard->shard_id()); | ||
| DCHECK(!args.empty()); | ||
| vector<OptString> respone(args.size()); |
iko1
force-pushed
the
fix/json-mget
branch
7 times, most recently
from
aaddf96 to
387ec7a
Compare
Signed-off-by: iko1 <[email protected]>
romange
approved these changes
Mar 2, 2023
|
Thanks, @iko1 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #849