fix(pytest): Add master restart delay #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
Signed-off-by: Vladislav Oleshko <[email protected]>
romange
reviewed
Mar 5, 2023
| @@ -52,6 +52,7 @@ def stop(self, kill=False): | |||
| except subprocess.TimeoutExpired: | |||
| print("Unable to terminate DragonflyDB gracefully, it was killed") | |||
| proc.kill() | |||
| proc.communicate() | |||
There was a problem hiding this comment.
why not print the results? https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate
or does it print it internally?
There was a problem hiding this comment.
Did you see the print above when test run? and where did you see the port print?
I found this fail for the disconnect replication fail and I dont see those prints
https://github.com/dragonflydb/dragonfly/actions/runs/4335282784/jobs/7569761257#step:6:1582
There was a problem hiding this comment.
Oh, its unrelated to the failing test, sorry, I just added this line for correctness
|
unrelated, maybe increase the timeout from 30min to 45? |
Signed-off-by: Vladislav Oleshko <[email protected]>
romange
approved these changes
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add small delay before re-starting master