Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): Change WaitForCallbacks mem order #914

Merged
merged 2 commits into from
Mar 6, 2023
Merged

fix(server): Change WaitForCallbacks mem order #914

merged 2 commits into from
Mar 6, 2023

Conversation

dranikpg
Copy link
Contributor

@dranikpg dranikpg commented Mar 6, 2023

// store operations below can not be ordered above the fence

is not the same as the meaning of release (i.e. its the opposite)

no reads or writes in the current thread can be reordered after this store

we need acquire, but actually also release to commit the results of the function that calls WaitForShardCallbacks

@dranikpg dranikpg requested a review from romange March 6, 2023 14:19
@romange romange merged commit 64e10f0 into dragonflydb:main Mar 6, 2023
@dranikpg dranikpg deleted the fix-tx branch March 14, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romange romange romange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dranikpg @romange