New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Pragmas from scripts #927

Merged

dranikpg merged 1 commit into dragonflydb:main from dranikpg:script-pragmas

Mar 12, 2023

Contributor

dranikpg commented Mar 11, 2023 •

edited

Loading

What format should pragmas use? Now I just parse the first line that goes

-- pragma: *pragmas*

I currently count settings from our base default, not from the configured ones. This means that script pragmas totally override everything, i.e. doing -- pragma: will reset to default state, even when the default script config flag had some pragmas included


          feat(server): Pragmas from scripts

Signed-off-by: Vladislav Oleshko <[email protected]>

dranikpg requested a review from romange

March 11, 2023 20:54

romange approved these changes

View reviewed changes

dranikpg merged commit 149b1fa into dragonflydb:main

dranikpg deleted the script-pragmas branch

March 14, 2023 13:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet