-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Add daily builds BFS verification #936
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/daily-builds
branch
2 times, most recently
from
March 14, 2023 10:28
21ea060
to
f707311
Compare
Pothulapati
commented
Mar 14, 2023
.github/workflows/daily-builds.yml
Outdated
strategy: | ||
matrix: | ||
# Build with these flags | ||
flags: ["-DMARCH_OPT=x86_64"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple build configurations can be added here
romange
requested changes
Mar 14, 2023
romange
reviewed
Mar 14, 2023
.github/workflows/daily-builds.yml
Outdated
strategy: | ||
matrix: | ||
# Build with these flags | ||
flags: ["-DMARCH_OPT=x86_64"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change it to -DMARCH_OPT="-march=x86_64"
or -DMARCH_OPT=-march=x86_64
.
Pothulapati
force-pushed
the
tar/daily-builds
branch
from
March 14, 2023 13:35
f707311
to
167979e
Compare
This commit adds a scheduled job that runs 8 AM Israel time every day, with common build configuration flags so that we can be sure that building from source for known configurations is possible.
Pothulapati
force-pushed
the
tar/daily-builds
branch
from
March 14, 2023 16:15
167979e
to
2460a1b
Compare
romange
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #732
This commit adds a scheduled job that runs 8 AM Israel time every day, with common build configuration flags so that we can be sure that building from source for known configurations is possible.