feat(server): Introduce and use TopKeys class. #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 16, 2023 10:53
TopKeys uses a custom implementation of HeavyKeeper to track top (hot) keys usage for debugging purposes. This commit also integrates TopKeys (default off) into DbTable and counts usage of (present) key lookups. Signed-off-by: chakaz <chakaz@chakaz>
Signed-off-by: chakaz <chakaz@chakaz>
Signed-off-by: chakaz <chakaz@chakaz>
This is a better API as it's less confusing. This feature is still disabled by default via the controlling flag. Signed-off-by: chakaz <chakaz@chakaz>
romange
reviewed
Mar 17, 2023
Signed-off-by: chakaz <chakaz@chakaz>
romange
approved these changes
Mar 17, 2023
|
This will be merged post 1.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopKeys uses a custom implementation of HeavyKeeper to track top (hot) keys usage for debugging purposes.
This commit also integrates TopKeys (default off) into DbTable and counts usage of (present) key lookups.
Fixes #257