tests(replication): Test script replication #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladislav Oleshko <[email protected]>
adiholden
reviewed
Mar 20, 2023
| local N = ARGV[1] | ||
|
|
||
| -- fill each list with its k value | ||
| for i, k in pairs(KEYS) do |
There was a problem hiding this comment.
you are passing keys, which are pairs and actually only the second of the pair is the key?
There was a problem hiding this comment.
No, this is just the default way to iterate a table in lua, like golangs for i, v := range slice
adiholden
reviewed
Mar 20, 2023
| for key_set in key_sets: | ||
| for j, k in enumerate(key_set): | ||
| l = await c_replica.lrange(k, 0, -1) | ||
| assert l == [f'{j}'.encode()] * num_ops |
There was a problem hiding this comment.
I believe we need to call
connection.connection_pool.disconnect()
so we will not get the error log
Task pending name='Task-3' coro=<Connection.disconnect() running at /usr/local/lib/python3.8/dist-packages/aioredis/connection.py:806>
There was a problem hiding this comment.
We need to do this in all tests, but even with it we might have those issues, lets look at it separately
adiholden
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test script replication with simple test
Fixes #885