chore: Improve client connection checking in pytests #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Mar 20, 2023
Also fix the compatibility of "client list" with redis-py client. Signed-off-by: Roman Gershman <[email protected]>
|
Ptal, i removed test filter
…On Mon, Mar 20, 2023, 14:21 adiholden ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/dragonfly/conftest.py
<#967 (comment)>
:
> @@ -149,6 +148,7 @@ async def async_client(async_pool):
Return an async client to the default instance with all entries flushed.
"""
client = aioredis.Redis(connection_pool=async_pool)
+ await client.client_setname("test")
this fixture runs for some pytests. I dont understand why you did this
change
—
Reply to this email directly, view it on GitHub
<#967 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BFCDRBEZ2HK6GXLR3U2TW5BDVVANCNFSM6AAAAAAWA7OIJM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
adiholden
reviewed
Mar 21, 2023
| @@ -281,7 +281,7 @@ def generate(max): | |||
|
|
|||
|
|
|||
| @pytest.mark.asyncio | |||
There was a problem hiding this comment.
why you did not remove the asyncio mark here?
There was a problem hiding this comment.
We have yet to do a proper clean-up for all the marks - just found a way to skip them
adiholden
reviewed
Mar 21, 2023
| await client.flushall() | ||
| return client | ||
| yield client |
There was a problem hiding this comment.
it does not matter here but in general, yielding is better because then you have a place to release resources if needed (after yield).
adiholden
reviewed
Mar 21, 2023
| @@ -252,7 +252,7 @@ async def disconnect(replica, c_replica, crash_type): | |||
|
|
|||
| # Check master survived all disconnects | |||
| assert await c_master.ping() | |||
|
|
|||
| await c_master.close() | |||
There was a problem hiding this comment.
all the replication tests have this problem not only this one.. and I believe there is bug in the aioredis lib version we use that close does not realy close and we need to use connection_pool.disconnect
I will open PR with this change
adiholden
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the compatibility of "client list" with redis-py client.