bug(helm): Fix parsing error with statefulset #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frédéric Marchand <[email protected]>
Pothulapati
reviewed
Mar 25, 2023
contrib/charts/dragonfly/Chart.yaml
Outdated
| @@ -21,7 +21,7 @@ version: v1.0.0 | |||
| # incremented each time you make changes to the application. Versions are not expected to | |||
| # follow Semantic Versioning. They should reflect the version the application is using. | |||
| # It is recommended to use it with quotes. | |||
| appVersion: "v1.0.0" | |||
| appVersion: "v1.0.1" | |||
There was a problem hiding this comment.
I don't think this is necessary, as we will update this version with a release candence containing all changes 👀
Pothulapati
reviewed
Mar 25, 2023
| @@ -86,7 +86,7 @@ containers: | |||
| {{- toYaml . | trim | nindent 6 }} | |||
| {{- end }} | |||
| {{- include "dragonfly.volumemounts" . | trim | nindent 4 }} | |||
| {{- if .Values.passwordFromSecret.enable -}} | |||
| {{- if .Values.passwordFromSecret.enable }} | |||
There was a problem hiding this comment.
Can you run the golden chart rendering command and also include those changes?
https://github.com/dragonflydb/dragonfly/blob/main/CONTRIBUTING.md#rendering-helm-golden-files
Signed-off-by: Frédéric Marchand <[email protected]>
Signed-off-by: Frédéric Marchand <[email protected]>
|
Thanks for fixing it @uncycler, I've also quickly added a test case so that we can test this support in the future. |
as they contain extra lines because of formatting
Pothulapati
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing the helm chart with persistence to true and using an existingSecret (or with only tls enabled), the following parsing error is triggered:
Error: YAML parse error on dragonfly/templates/statefulset.yaml: error converting YAML to JSON: yaml: line 61: did not find expected key.
This simple PR fixes this.