feat: implement recursive download for dfget #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 12.47% 12.32% -0.16%
==========================================
Files 55 55
Lines 9952 10077 +125
==========================================
Hits 1242 1242
- Misses 8710 8835 +125
|
Lzzzzzt
force-pushed
the
recusive-download
branch
3 times, most recently
from
3733d46 to
9ade0cb
Compare
BruceAko
suggested changes
Jul 18, 2024
|
Redundant signature information. |
Lzzzzzt
force-pushed
the
recusive-download
branch
from
9ade0cb to
c58a83f
Compare
Signed-off-by: lzzzt <[email protected]> feat: implement recursive download for dfget Signed-off-by: lzzzt <[email protected]>
Lzzzzzt
force-pushed
the
recusive-download
branch
from
c58a83f to
494389d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement recursive download for dfget
Description
This PR completes with the following tasks:
download_tasksto download the directorydownload_taskto download single fileOther details will be shown in the code.
Related Issue
#496
Motivation and Context
Dragonfly rust client does not support back-to-source downloading of different object storage protocols. Priority is given to supporting OSS protocol back-to-source downloads. Need to support OSS protocol in dragonfly-client-backend crate, implemented based on trait Backend and it needs to support directory recursive downloading.
Screenshots