Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase braking to ISO 15622-2018; tune accelerating. #114

Closed

Conversation

wer5lcy
Copy link

@wer5lcy wer5lcy commented Nov 12, 2021

I changed the DP acceleration profile in 0.8.8. After that, compared to stock openpilot acceleration profile, when using DP profiles, my car still occasionally unable to stop behind stationary cars. Therefore I increased decel curve to what ISO 15622-2018 writes, leaving braking to the model, and I've tested 300km.

Please try this profile on your cars before merging.

@rav4kumar
Copy link

if you can test it on 0810 once its out then we can probably merge it since it has retuned mpc

@wer5lcy
Copy link
Author

wer5lcy commented Nov 13, 2021

I've give it a retry. About a week.

@wer5lcy
Copy link
Author

wer5lcy commented Nov 17, 2021

The acc&dec profile is working in 0.8.10, both with and without lead cars. However, my CorollaH TSS2 is suffering more from insufficient acceleration in 0.8.10. Please close this PR for now or merge it into 0.8.9.

@MiDe84
Copy link

MiDe84 commented Nov 22, 2021

Would this braking change also apply to GM cars? I switched to 8.10 cause 8.9 was trying to rear end everyone with my 2017 GM Volt.

@MiDe84
Copy link

MiDe84 commented Nov 22, 2021

Would this braking change also apply to GM cars? I switched to 8.10 cause 8.9 was trying to rear end everyone with my 2017 GM Volt.

I actually answered this question myself. I jumped over to https://github.com/wer5lcy/openpilot/tree/Re-tune-DP-braking-curve and the issue of trying to run into the backs of cars came back. It seems like its not braking with the physical brakes only the regenerative braking only. Stock long does not have this issue as the current 8.10 works fine as far as braking goes.

@wer5lcy wer5lcy closed this Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants