Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation is too naive #160

Closed
drahnr opened this issue Mar 12, 2021 · 0 comments · Fixed by #162
Closed

Segmentation is too naive #160

drahnr opened this issue Mar 12, 2021 · 0 comments · Fixed by #162
Assignees
@drahnr
Labels
bug Something isn't working

Comments

@drahnr
Copy link
Owner

drahnr commented Mar 12, 2021

Describe the bug

Right now segmentation is very primitive. Segmentations are not based on context, but on hardcoded chars.

To Reproduce

Steps to reproduce the behaviour:

  1. A file containing pre-historic
  2. Run cargo spellcheck ...
  3. no way to whitlist since it's recognized as two different words

Expected behavior

Keep pre-historic as one word.

Screenshots

Please complete the following information:

  • System: Fedora
  • Obtained: git, cargo
  • Version: 0.7.1

Additional context

Should be implemented via bminixhofer/srx#4 since the rule content is already included in the binary.
@drahnr drahnr added the bug Something isn't working label Mar 12, 2021
@drahnr drahnr self-assigned this Mar 12, 2021
@drahnr drahnr mentioned this issue Mar 17, 2021
Merged
3 tasks
@drahnr drahnr changed the title Segmentation is too native Segmentation is too naive Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drahnr drahnr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better tokenization drahnr/cargo-spellcheck
1 participant
@drahnr