better tokenization #162
Merged
better tokenization #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
force-pushed
the
bernhard-better-tokenization
branch
from
4671e6d to
459db7d
Compare
KuabeM
approved these changes
Mar 17, 2021
drahnr
force-pushed
the
bernhard-better-tokenization
branch
from
459db7d to
ec7d74c
Compare
drahnr
force-pushed
the
bernhard-better-tokenization
branch
from
013351a to
e7202b2
Compare
drahnr
force-pushed
the
bernhard-better-tokenization
branch
from
3a6008e to
27bd2ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR accomplish?
Replace the current naive tokenization with srx/nlprule based tokenization.
Closes #160 .
Changes proposed by this PR:
Use
nlprulefor segmentation.Notes to reviewer:
Currently this is still dysfunctional, since the
Token<'t>ranges are not relative to the input text, but to the sentence.Blocked by bminixhofer/nlprule#53
📜 Checklist
./demosub directory