Fix in netmasks #1091
Merged
Fix in netmasks #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an expression had an xxx in (a, b, c, ...) check, the values a, b, c would be put in a set and xxx would do a set membership test to see if it's in the set. For almost all filtercheck types, this is preferred, but for some types like PT_IPV4NET, you can't actually do set membership tests, as the notion of equals isn't a simple == operator. So for PT_IPV4NET and any type that trivially returns false from ::flt_compare(), instead of doing the set membership test, compare the filtercheck values individually and return true as soon as you find one that is equal. This fixes falcosecurity/falco#339.
If a filter check has an in operator against a set of values, which gets turned into a piecewise equality comparison, treat the operator CO_IN just like CO_EQ.
mstemm
added a commit
to falcosecurity/falco
that referenced
this pull request
Apr 2, 2018
Tests fix for #339. Depends on draios/sysdig#1091.
mstemm
added a commit
to falcosecurity/falco
that referenced
this pull request
Apr 4, 2018
Tests fix for #339. Depends on draios/sysdig#1091.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an expression had an xxx in (a, b, c, ...) check, the
values a, b, c would be put in a set and xxx would do a set membership
test to see if it's in the set.
For almost all filtercheck types, this is preferred, but for some types
like PT_IPV4NET, you can't actually do set membership tests, as the
notion of equals isn't a simple == operator.
So for PT_IPV4NET and any type that trivially returns false from
::flt_compare(), instead of doing the set membership test, compare the
filtercheck values individually and return true as soon as you find one
that is equal.
This fixes falcosecurity/falco#339.