Filterchecks flags cleanup #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evt.dir was flagged as EPF_PRINT_ONLY, but it can be used in filters as well. Fix the flag.
Many filters required an argument in the form .arg or [arg], but they didn't have the flag EPF_REQUIRES_ARGUMENT. This flag wasn't used anywhere, but we plan on using it in falco soon, so it needs to be accurate. Do a pass over all filterchecks that call extract_arg and add EPF_REQUIRES_ARGUMENT as needed.
mstemm
force-pushed
the
filterchecks-flags-cleanup
branch
from
c3a1fd8 to
51d9d65
Compare
mattpag
requested changes
May 3, 2018
Missed some in the previous commit.
|
Thanks for double checking. I added the others though. |
|
Yeah, I added them because I supposed you wanted to use that flag in falco as an indicator of a possible argument, whether mandatory or not. |
mattpag
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several changes to update the flags used for filterchecks to make them accurately reflect how they can be used.
This is related to some falco changes in falcosecurity/falco#364.
@mattpag can you double-check the changes?