Add 'endswith' filter #1209
Merged
Add 'endswith' filter #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysdig-CLA-1.0-signed-off-by: Simon Major <[email protected]>
|
Don't merge - failing for buffers |
sysdig-CLA-1.0-signed-off-by: Simon Major <[email protected]>
|
The changes look good. The reason the sign off checker isn't working is that it wants the CLA message in every commit. Do you just want to rebase to squash the last two commits together? |
|
Will do - had a massive hardware failure today so might be a couple of days before I can rebase, squash and merge - I'm happy to forgo any legalese if the changes can be made "internally" before I can get a working dev env created before the next release |
sysdig-CLA-1.0-signed-off-by: Simon Major <[email protected]>
majorsimon
force-pushed
the
add-endswith-filter
branch
from
ff34737 to
bf75d41
Compare
mstemm
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should handle #1208
sysdig-CLA-1.0-signed-off-by: Simon Major [email protected]