[SMAGENT-2075] installer removes older sysdig-probes before loading newly built probe #1558
Conversation
scott-greenberg-sysdig
requested review from
adalton,
speedyguy17 and
balinaveen
| @@ -196,3 +196,5 @@ elif [ -f /etc/system-release-cpe ]; then | |||
| else | |||
| unsupported | |||
| fi | |||
|
|
|||
| modprobe -r _COMPONENT__probe | |||
There was a problem hiding this comment.
Your description says you're loading a module. man modprobe says:
-r, --remove
This option causes modprobe to remove rather than insert a module.
There was a problem hiding this comment.
this has been changed to remove -r flag in latest commit
There was a problem hiding this comment.
reverting change; the reason why we have the -r flag is because sysdig automatically loads the newest probe, but in a situation where we are upgrading from a previous sysdig version the newer probe cannot be loaded because the older ver. probe is already loaded and has the same name as the newer probe module. This change ensures this won't happen.
There was a problem hiding this comment.
does the probe get unloaded when you exit an instance of sysdig?
There was a problem hiding this comment.
@speedyguy17 no, it stays loaded.
scott-greenberg-sysdig
changed the title
|
This has now been tested |
scott-greenberg-sysdig
changed the title
Added modprobe line to load newly built probe in sysdig install script