Fix compile errors on Linux 5.6 due to timespec / timeval #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnosek
reviewed
Apr 29, 2020
fntlnz
reviewed
Apr 29, 2020
There was a problem hiding this comment.
Nice approach @nathan-b - I was looking at this issue myself too and came up with a totally different approach, but wow I like this much more than mine!
I added some comments here and there, minor things.
I also noticed this PR does not affect the bpf driver yet, is that intended:
- https://github.com/draios/sysdig/blob/y2038/driver/bpf/fillers.h#L929
- https://github.com/draios/sysdig/blob/y2038/driver/bpf/fillers.h#L543
Thanks
|
Thanks for the comments everyone! Trying again ;) |
gnosek
approved these changes
Apr 29, 2020
|
@fntlnz wanna take a look at the eBPF changes? |
fntlnz
approved these changes
Apr 30, 2020
leodido
approved these changes
Apr 30, 2020
This was referenced Apr 30, 2020
Molter73
pushed a commit
to stackrox/falcosecurity-libs
that referenced
this pull request
Sep 17, 2021
Adapt upstream sysdig changes (draios/sysdig#1621 and draios/sysdig#1672) to fix compile errors on due to timespec / timeval and kernel module compilation on 5.8 # Conflicts: # driver/bpf/fillers.h # driver/kernel_hacks.h # driver/main.c # driver/ppm.h # driver/ppm_fillers.c
Molter73
pushed a commit
to stackrox/falcosecurity-libs
that referenced
this pull request
Sep 17, 2021
Adapt upstream sysdig changes (draios/sysdig#1621 and draios/sysdig#1672) to fix compile errors on due to timespec / timeval and kernel module compilation on 5.8 # Conflicts: # driver/bpf/fillers.h # driver/kernel_hacks.h # driver/main.c # driver/ppm.h # driver/ppm_fillers.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.