Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): wrong bash expansion #1976

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix(scripts): wrong bash expansion #1976

merged 1 commit into from
Mar 22, 2023

Conversation

therealbobo
Copy link
Contributor

This corrects some unnecessary double quotes that break the scap-driver-loader script.

@therealbobo
fix(scripts): wrong bash expansion
f3981f1 
Signed-off-by: Roberto Scolaro <[email protected]>
LucaGuerra
LucaGuerra approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@LucaGuerra LucaGuerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@LucaGuerra
Copy link
Contributor

Unfortunately this was preventing the falco-driver-loader from download drivers at all :/

@therealbobo therealbobo merged commit 654a709 into draios:dev Mar 22, 2023
@BrewTestBot BrewTestBot mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaGuerra LucaGuerra LucaGuerra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therealbobo @LucaGuerra