fix(reply_builder): remove virtual modifier in SendError(ErrorReply) …

…method (dragonflydb#3191) fixes dragonflydb#3190 Signed-off-by: Stepan Bagritsevich <[email protected]>
dranikpg · Jun 23, 2024 · 4701272 · 4701272
1 parent c60cd7e
commit 4701272
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/src/facade/reply_builder.h b/src/facade/reply_builder.h
@@ -79,8 +79,8 @@ class SinkReplyBuilder {
   }
 
   virtual void SendError(std::string_view str, std::string_view type = {}) = 0;  // MC and Redis
-  virtual void SendError(ErrorReply error);
   virtual void SendError(OpStatus status);
+  void SendError(ErrorReply error);
 
   virtual void SendStored() = 0;  // Reply for set commands.
   virtual void SendSetSkipped() = 0;

diff --git a/src/facade/reply_capture.cc b/src/facade/reply_capture.cc
@@ -21,11 +21,6 @@ void CapturingReplyBuilder::SendError(std::string_view str, std::string_view typ
   Capture(Error{str, type});
 }
 
-void CapturingReplyBuilder::SendError(ErrorReply error) {
-  SKIP_LESS(ReplyMode::ONLY_ERR);
-  Capture(Error{error.ToSv(), error.kind});
-}
-
 void CapturingReplyBuilder::SendMGetResponse(MGetResponse resp) {
   SKIP_LESS(ReplyMode::FULL);
   Capture(std::move(resp));

diff --git a/src/facade/reply_capture.h b/src/facade/reply_capture.h
@@ -24,12 +24,12 @@ class CapturingReplyBuilder : public RedisReplyBuilder {
 
  public:
   void SendError(std::string_view str, std::string_view type = {}) override;
-  void SendError(ErrorReply error) override;
   void SendMGetResponse(MGetResponse resp) override;
 
   // SendStored -> SendSimpleString("OK")
   // SendSetSkipped -> SendNull()
   void SendError(OpStatus status) override;
+  using RedisReplyBuilder::SendError;
 
   void SendNullArray() override;
   void SendEmptyArray() override;