Remove Fixed Dapr Version Constraint #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruokun-niu
requested review from
amansinghoriginal,
danielgerlag and
agentofreality
.github/workflows/build-test.yml
Outdated
| @@ -372,7 +372,7 @@ jobs: | |||
| permissions: | |||
| packages: write | |||
| contents: read | |||
| runs-on: e2e-tester | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Don't forget about this.
cli/service/resources/infra.yaml
Outdated
| - name: password | ||
| value: | ||
| - name: connectionString | ||
| value: "mongodb://drasi-mongo-0.drasi-mongo:27017/?replicaSet=rs0" |
There was a problem hiding this comment.
Is this always going to connect to the -0 instance? Is there somekind of service proxy to route to any of the available instances?
There was a problem hiding this comment.
I think we can use the service name (drasi-mongo) instead. I'll test this to make sure things are working
There was a problem hiding this comment.
I have just tested this. We can use the service name in the connectionstring (`"mongodb://drasi-mongo:27017/?replicaSet=rs0")
| @@ -31,7 +31,7 @@ | |||
| queryIds.Add(queryId); | |||
| } | |||
|
|
|||
|
|
|||
| Console.WriteLine("QueryContainerId: " + queryContainerId); | |||
There was a problem hiding this comment.
This doesn't seem related to DAPR version?
There was a problem hiding this comment.
Good catch. Thanks
There was a problem hiding this comment.
The addition of await on line 142 in this file is minor fix for the result reaction. Encountered this occasionally when I attempted the smoke test
amansinghoriginal
approved these changes
Feb 18, 2025
agentofreality
approved these changes
Feb 19, 2025
ruokun-niu
added a commit
to ruokun-niu/drasi-platform
that referenced
this pull request
Mar 4, 2025
…/drasi-platform into review-debug-reaction * 'review-debug-reaction' of https://github.com/ruokun-niu/drasi-platform: Transition to Native Multi-Platform Builds for Docker Images (drasi-project#161) Bump jinja2 from 3.1.4 to 3.1.5 in /reactions/sdk/python (drasi-project#135) Bump vite in /reactions/signalr/signalr-reaction/clients/vue (drasi-project#142) Bump nanoid in /reactions/signalr/signalr-reaction/clients/react/example (drasi-project#131) Bump openssl from 0.10.66 to 0.10.71 in /query-container (drasi-project#160) Bump golang.org/x/crypto from 0.26.0 to 0.31.0 in /cli (drasi-project#132) Bump nanoid in /reactions/signalr/signalr-reaction/clients/vue/example (drasi-project#130) Bump openssl from 0.10.68 to 0.10.71 in /sources/sdk/rust/example/proxy (drasi-project#158) Bump io.undertow:undertow-core from 2.3.15.Final to 2.3.17.Final in /sources/sdk/java (drasi-project#127) Bump esbuild from 0.16.17 to 0.25.0 in /dev-tools/vscode/drasi (drasi-project#151) Bump openssl from 0.10.66 to 0.10.70 in /control-planes/mgmt_api (drasi-project#148) Remove Fixed Dapr Version Constraint (drasi-project#147) Gremlin Reaction hotfix (drasi-project#149)
ruokun-niu
added a commit
to ruokun-niu/drasi-platform
that referenced
this pull request
Mar 4, 2025
…si-platform into debug-base-images * 'debug-base-images' of https://github.com/ruokun-niu/drasi-platform: Transition to Native Multi-Platform Builds for Docker Images (drasi-project#161) Bump jinja2 from 3.1.4 to 3.1.5 in /reactions/sdk/python (drasi-project#135) Bump vite in /reactions/signalr/signalr-reaction/clients/vue (drasi-project#142) Bump nanoid in /reactions/signalr/signalr-reaction/clients/react/example (drasi-project#131) Bump openssl from 0.10.66 to 0.10.71 in /query-container (drasi-project#160) Bump golang.org/x/crypto from 0.26.0 to 0.31.0 in /cli (drasi-project#132) Bump nanoid in /reactions/signalr/signalr-reaction/clients/vue/example (drasi-project#130) Bump openssl from 0.10.68 to 0.10.71 in /sources/sdk/rust/example/proxy (drasi-project#158) Bump io.undertow:undertow-core from 2.3.15.Final to 2.3.17.Final in /sources/sdk/java (drasi-project#127) Bump esbuild from 0.16.17 to 0.25.0 in /dev-tools/vscode/drasi (drasi-project#151) Bump openssl from 0.10.66 to 0.10.70 in /control-planes/mgmt_api (drasi-project#148) Remove Fixed Dapr Version Constraint (drasi-project#147) Gremlin Reaction hotfix (drasi-project#149) EventHub Source (drasi-project#152) Configured the EventGrid Reaction to use different schemas (drasi-project#138) AWS IRSA support and Eventbridge reaction (drasi-project#140) init logging (drasi-project#153) Dotnet source sdk (drasi-project#144) Refactor Relational Source and add MySQL Support. (drasi-project#146)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We previously had to use a fixed verison of the dapr runtime (1.10.0), as we would run into the following error when we try to run
drasi initwith the latest version of dapr:error saving actor transaction state: using transactions with MongoDB requires connecting to a replica setThis also restricted us to use the 1.9.0 version of the dapr sidecar.
Initially, I thought this was an issue with how we setup mongo in the Drasi cluster. However, after exploring a bit, I realized that the issue was with how we set up mongo as the dapr statestore. When we specify the mongo during the state store definition, we need to specifically point towards a mongo replicaset, which can be defined in the
connectionStringfield.NOTE: In the official dapr documentation on using mongo as a state store,
connectionStringis not listed as a valid field. However, according to this discord discussion and this PR, this field is actually added in 2024 and they just forgot to update the doc site. By defining a connection string to the replicaset ininfra.yaml, dapr will correctly use the replica set as the mongo actor state store, which allows us to install Drasi with the latest version of dapr without any trouble.The description below is generated by copilot :)
This pull request includes changes to the
clipackage to update the configuration for Dapr versions and MongoDB connection settings. The most important changes are as follows:Updates to Dapr version configuration:
cli/cmd/init.go: Updated the default values fordapr-runtime-versionto be empty (which is the equivalent of latest) anddapr-sidecar-versionto "latest".Changes to MongoDB connection settings:
cli/service/resources/infra.yaml: Replaced individual host, username, and password metadata with a singleconnectionStringfor MongoDB, including a comment explaining the necessity of thereplicaSetparameter.cli/service/resources/infra.yaml: Removed an unnecessary blank line.Type of change
Fixes: #issue_number