Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commas in value and total of progressBar #388

Merged
merged 3 commits into from
May 20, 2021

Conversation

swsoyee
Copy link
Contributor

@swsoyee swsoyee commented May 15, 2021

Feel free to edit this PR : )

127 0 0 1_3057_

@swsoyee
Copy link
Contributor Author

swsoyee commented May 20, 2021

@pvictor Hi, would you mind checking this PR?

@pvictor
Copy link
Member

pvictor commented May 20, 2021

Sure, I understand the progressbar changes but what have you modified in shinyWidgets.css ?

I don't use this file anymore, and neither does uglify.R (I should remove them)

JavaScript (shinyWidgets-bindings.min.js) & CSS (shinyWidgets.min.css) files are created in ìnst/assets/tools.R (note it require this package to execute: https://github.com/dreamRs/jstools)

@swsoyee
Copy link
Contributor Author

swsoyee commented May 20, 2021

Thanks, I didn't modify any shinyWidgets.css, it's updated by uglify.R automatically, so I thought it was caused by forgetting to sync the update (commit in 60e0830).

JavaScript (shinyWidgets-bindings.min.js) & CSS (shinyWidgets.min.css) files are created in ìnst/assets/tools.R (note it require this package to execute: https://github.com/dreamRs/jstools)

Thank you for the development suggestions, I will fix these non-essential changes later.

@pvictor
Copy link
Member

pvictor commented May 20, 2021

Ok! it was to be sure not to lose any of your modifications

I can merge like that, that's good for me

@pvictor pvictor merged commit 4937454 into dreamRs:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants