Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding position absolute to awesomeCheckboxGroup #390

Merged
merged 2 commits into from
May 25, 2021

Conversation

MayaGans
Copy link
Contributor

World's tiniest PR: This closes #389 !

Changelog:

  1. added position: absolute; to awesome-boostrap-checkbox.scss
  2. ran compile-css.R
....
  input[type="checkbox"],
  input[type="radio"] {
    opacity: 0;
    z-index: 1;
    cursor: pointer;
    position: absolute;
....

the little example in my issue and also ran the checks:

── R CMD check results ──────────────────────────── shinyWidgets 0.6.0.9100 ────
Duration: 47.8s

0 errors ✓ | 0 warnings ✓ | 0 notes ✓

R CMD check succeeded

@pvictor
Copy link
Member

pvictor commented May 25, 2021

Hi Maya,

Thanks for the PR!
This seems indeed better with your changes, but now the checkboxes overflow the parent container on the left and are no longer aligned with the label.

image

More visible in the gallery:

image

It only affects checkboxes.

Increasing left padding to 20px seems to fix that (here:

)

What do you think ?

Victor

@MayaGans
Copy link
Contributor Author

MayaGans commented May 25, 2021

Ah that's perfect!! Thanks for having my back @pvictor and looking at other widgets 🤦‍♀️ I added your suggestion here and re-built the scss, let me know if there's anything else you'd need from me!

@pvictor pvictor merged commit 1e755e5 into dreamRs:master May 25, 2021
@pvictor
Copy link
Member

pvictor commented May 25, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awesomeCheckboxGroup alignment
2 participants