Skip to content

Commit

Permalink
Use the latest version of amazon-efs-utils and move to 2.x
Browse files Browse the repository at this point in the history
  • Loading branch information
dreambeyondorange committed Jan 21, 2025
1 parent 2b32e47 commit 5aaebee
Show file tree
Hide file tree
Showing 12 changed files with 19 additions and 26 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,12 @@ jobs:
matrix:
os: [ubuntu-latest]
name:
- Python 3.7 Tests
- Python 3.8 Tests
- Python 3.9 Tests
- Python 3.10 Tests
- Python 3.10 Tests Coverage
- Code Checks
include:
- name: Python 3.7 Tests
python: 3.7
toxenv: py37-nocov
- name: Python 3.8 Tests
python: 3.8
toxenv: py38-nocov
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ This file is used to list changes made in each version of the AWS ParallelCluste
**CHANGES**
- On Ubuntu 22.04, install the Nvidia driver with the same compiler version used to compile the kernel.
- Upgrade `aws-cfn-bootstrap` to version 2.0-32.
- Upgrade amazon-efs-utils to version 2.1.0.

3.12.0
------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@

action :install_utils do
package_name = "amazon-efs-utils"

full_package = "#{package_name}-#{new_resource.efs_utils_version}"
# Do not install efs-utils if a same or newer version is already installed.
return if already_installed?(package_name, new_resource.efs_utils_version)

# On Amazon Linux 2, amazon-efs-utils and stunnel are installed from OS repo.
package package_name do
package full_package do
retries 3
retry_delay 5
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
use 'partial/_mount_umount'

action :install_utils do
package_name = "amazon-efs-utils"
package_name = "amazon-efs-utils-#{new_resource.efs_utils_version}"

# Do not install efs-utils if a same or newer version is already installed.
return if already_installed?(package_name, new_resource.efs_utils_version)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,3 @@
use 'partial/_redhat_based'
use 'partial/_install_from_tar'
use 'partial/_mount_umount'

def prerequisites
%w(rpm-build make)
end
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,3 @@
use 'partial/_redhat_based'
use 'partial/_install_from_tar'
use 'partial/_mount_umount'

def prerequisites
%w(rpm-build make)
end
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

default_action :install_utils

property :efs_utils_version, String, default: '1.34.1'
property :efs_utils_checksum, String, default: '69d0d8effca3b58ccaf4b814960ec1d16263807e508b908975c2627988c7eb6c'
property :efs_utils_version, String, default: '2.1.0'
property :efs_utils_checksum, String, default: '2996bdd5387131d302310812fa1e07e1be00f80814a580f5dfeb27d68519fd24'

def already_installed?(package_name, expected_version)
Gem::Version.new(get_package_version(package_name)) >= Gem::Version.new(expected_version)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ def install_script_code(efs_utils_tarball, efs_utils_package, efs_utils_version)
end

def prerequisites
%w(dkms)
%w(dkms pkg-config libssl-dev rustc cargo )
end
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,7 @@ def install_script_code(efs_utils_tarball, efs_utils_package, efs_utils_version)
yum -y install ./build/#{efs_utils_package}*rpm
EFSUTILSINSTALL
end

def prerequisites
%w(rpm-build make rust cargo openssl-devel)
end
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def mock_already_installed(package, expected_version, installed)

it 'installs amazon-efs-utils' do
is_expected.to install_utils_efs('install_utils')
is_expected.to install_package('amazon-efs-utils').with(retries: 3).with(retry_delay: 5)
is_expected.to install_package('amazon-efs-utils-1.2.3').with(retries: 3).with(retry_delay: 5)
end
end

Expand All @@ -73,7 +73,7 @@ def mock_already_installed(package, expected_version, installed)
end

it 'installs amazon-efs-utils' do
is_expected.to install_package('amazon-efs-utils').with(retries: 3).with(retry_delay: 5)
is_expected.to install_package('amazon-efs-utils-1.2.3').with(retries: 3).with(retry_delay: 5)
end
end
end
Expand Down Expand Up @@ -179,8 +179,8 @@ def mock_already_installed(package, expected_version, installed)
end
cached(:required_packages) do
{
"redhat" => %w(rpm-build make),
"rocky" => %w(rpm-build make),
"redhat" => %w(rpm-build make rust cargo openssl-devel),
"rocky" => %w(rpm-build make rust cargo openssl-devel),
}
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

only_if { !os_properties.redhat_on_docker? }

describe file("#{node['cluster']['sources_dir']}/efs-utils-1.34.1.tar.gz") do
describe file("#{node['cluster']['sources_dir']}/efs-utils-2.1.0.tar.gz") do
it { should exist }
its('sha256sum') { should eq '69d0d8effca3b58ccaf4b814960ec1d16263807e508b908975c2627988c7eb6c' }
its('sha256sum') { should eq '2996bdd5387131d302310812fa1e07e1be00f80814a580f5dfeb27d68519fd24' }
its('owner') { should eq 'root' }
its('group') { should eq 'root' }
its('mode') { should cmp '0644' }
Expand Down
4 changes: 2 additions & 2 deletions kitchen.ec2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ platforms:
image_id: <%= ENV['KITCHEN_UBUNTU2004_AMI'] %>
<% else %>
image_search:
name: <% if ENV['KITCHEN_PHASE']=='install' %>ubuntu/images/hvm-ssd/ubuntu-focal-20.04-<% if ENV['KITCHEN_ARCHITECTURE'] == 'x86_64' %>amd64<% else %>arm64<% end %>-server-20230112<% else %><%= pcluster_prefix %>-ubuntu-2004-lts-hvm-*<% end %>
name: <% if ENV['KITCHEN_PHASE']=='install' %>ubuntu/images/hvm-ssd/ubuntu-focal-20.04-<% if ENV['KITCHEN_ARCHITECTURE'] == 'x86_64' %>amd64<% else %>arm64<% end %>-server-<% else %><%= pcluster_prefix %>-ubuntu-2004-lts-hvm-*<% end %>
architecture: <%= ENV['KITCHEN_ARCHITECTURE'] %>
<% end %>
block_device_mappings:
Expand All @@ -271,7 +271,7 @@ platforms:
image_id: <%= ENV['KITCHEN_UBUNTU2204_AMI'] %>
<% else %>
image_search:
name: <% if ENV['KITCHEN_PHASE']=='install' %>ubuntu/images/hvm-ssd/ubuntu-jammy-22.04-<% if ENV['KITCHEN_ARCHITECTURE'] == 'x86_64' %>amd64<% else %>arm64<% end %>-server-20230106<% else %><%= pcluster_prefix %>-ubuntu-2204-lts-hvm-*<% end %>
name: <% if ENV['KITCHEN_PHASE']=='install' %>ubuntu/images/hvm-ssd/ubuntu-jammy-22.04-<% if ENV['KITCHEN_ARCHITECTURE'] == 'x86_64' %>amd64<% else %>arm64<% end %>-server-<% else %><%= pcluster_prefix %>-ubuntu-2204-lts-hvm-*<% end %>
architecture: <%= ENV['KITCHEN_ARCHITECTURE'] %>
<% end %>
block_device_mappings:
Expand Down

0 comments on commit 5aaebee

Please sign in to comment.