Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dbt-core dependency #1

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Update dbt-core dependency #1

merged 2 commits into from
Sep 29, 2022

Conversation

jlarue26
Copy link
Contributor

  • Adapter requires version [1.2.0 .. 1.2.1]

Update dbt-core dependency
2f54ffc 
- Adapter requires version [1.2.0 .. 1.2.1]
@jlarue26 jlarue26 self-assigned this Sep 27, 2022
@jlarue26 jlarue26 changed the title WIP: Update dbt-core dependency Update dbt-core dependency Sep 27, 2022
@jlarue26
Copy link
Contributor Author

jlarue26 commented Sep 27, 2022 •
edited
Loading

Adapter now depends on dbt-core version 1.2.x
Initially added dependency to be >=1.2.1, but that pulled in 1.3.0b2 which is definitely not what we want.

ArgusLi
ArgusLi approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@ArgusLi ArgusLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the compatible release "~=" is a great idea.

@jlarue26
Copy link
Contributor Author

jlarue26 commented Sep 27, 2022 •
edited
Loading

Summary

Update dbt-core dependency

Description

Updated install_requires in setup.py to be any dbt-core version 1.2.x.

Related Issue

#2: Update dbt-core dependency

Additional Reviewers

@ravjotbrar
@ArgusLi

@jlarue26 jlarue26 merged commit 44dcfd2 into main Sep 29, 2022
@jlarue26 jlarue26 deleted the dbt-core-upgrade branch September 29, 2022 23:26
@darian-heede darian-heede mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravjotbrar ravjotbrar ravjotbrar approved these changes

@ArgusLi ArgusLi ArgusLi approved these changes

Assignees

@jlarue26 jlarue26

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlarue26 @ArgusLi @ravjotbrar