Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement setting/clearing thermostat schedule #3155

Merged
merged 14 commits into from
Aug 20, 2020
Merged

Implement setting/clearing thermostat schedule #3155

merged 14 commits into from
Aug 20, 2020

Conversation

ebaauw
Copy link
Collaborator

@ebaauw ebaauw commented Aug 16, 2020

ebaauw added 9 commits August 15, 2020 13:07
See #2393.  Note that the TRV is not yet updated.
- Stop polling the gateway device.
- Use Zigbee epoch for time sync, as deCONZ code v2.05.80 now handles `utc` correctly.
- Use Zigbee epoch for time sync, as deCONZ code v2.05.80 now handles `utc` correctly.
@ebaauw ebaauw linked an issue Aug 16, 2020 that may be closed by this pull request
@manup
Copy link
Member

manup commented Aug 17, 2020

Stop trying to poll the gateway device. Gateway now no longer issues route requests for itself (NWK 0x0000).

Nice, saw that the other day in a sniffer log. Still a bit strange why it caused route requests as other requests for ZDP stuff also work for the gateway.

@ebaauw
Copy link
Collaborator Author

ebaauw commented Aug 17, 2020

WTF, I get compile errors on Stretch

$ qmake -v
QMake version 3.0
Using Qt version 5.7.1 in /usr/lib/arm-linux-gnueabihf
$ uname -a
Linux pi1 4.19.66-v7+ #1253 SMP Thu Aug 15 11:49:46 BST 2019 armv7l GNU/Linux

No issues on Buster

$ qmake -v
QMake version 3.1
Using Qt version 5.11.3 in /usr/lib/arm-linux-gnueabihf
$ uname -a
Linux pi6 5.4.51-v7l+ #1333 SMP Mon Aug 10 16:51:40 BST 2020 armv7l GNU/Linux

ebaauw added 3 commits August 17, 2020 16:00
Another place where devices are queued for polling.
Unused variable.
@ebaauw ebaauw requested review from Smanar and manup August 17, 2020 20:23
@ebaauw
Copy link
Collaborator Author

ebaauw commented Aug 17, 2020

I think this PR is good to go. @manup @SwoopX could you please have a look?

I still see one "poll node" message for the gateway device, shortly after startup. I don't know where it comes from.

Damn, one more `utc` field.
thermostat.cpp Show resolved Hide resolved
thermostat.cpp Outdated Show resolved Hide resolved
Use `.at(#)` instead of `[#]` for `QVariantList` entries.
@ebaauw ebaauw requested a review from SwoopX August 20, 2020 18:07
@ebaauw ebaauw merged commit d5c3c8f into dresden-elektronik:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Device Support Request - eCozy Smart Heating Thermostat
3 participants