Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip update tests under Java test server #1

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions tests/updates_and_signals/safe_message_handlers/workflow_test.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
import asyncio
import uuid

import pytest
from temporalio.client import Client, WorkflowUpdateFailedError
from temporalio.exceptions import ApplicationError
from temporalio.testing import WorkflowEnvironment
from temporalio.worker import Worker

from updates_and_signals.safe_message_handlers.activities import (
Expand All @@ -18,7 +20,11 @@
)


async def test_safe_message_handlers(client: Client):
async def test_safe_message_handlers(client: Client, env: WorkflowEnvironment):
if env.supports_time_skipping:
pytest.skip(
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
)
task_queue = f"tq-{uuid.uuid4()}"
async with Worker(
client,
Expand Down Expand Up @@ -66,7 +72,11 @@ async def test_safe_message_handlers(client: Client):
assert result.num_currently_assigned_nodes == 0


async def test_update_idempotency(client: Client):
async def test_update_idempotency(client: Client, env: WorkflowEnvironment):
if env.supports_time_skipping:
pytest.skip(
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
)
task_queue = f"tq-{uuid.uuid4()}"
async with Worker(
client,
Expand Down Expand Up @@ -101,7 +111,11 @@ async def test_update_idempotency(client: Client):
assert result_1.nodes_assigned >= result_2.nodes_assigned


async def test_update_failure(client: Client):
async def test_update_failure(client: Client, env: WorkflowEnvironment):
if env.supports_time_skipping:
pytest.skip(
"Java test server: https://github.com/temporalio/sdk-java/issues/1903"
)
task_queue = f"tq-{uuid.uuid4()}"
async with Worker(
client,
Expand Down