Hotfix: CosMx Convenience #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: use utility now exported from GiottoUtils
## Bug fixes: * fix `createGiottoCosMxObject()` not passing `load_expression`, `load_cellmeta`, `load_transcripts` params to `importCosMx()` ## Enhancements * `poly_pref` param for `createGiottoCosMxObject()` and `importCosMx()` to select between loading the mask images or the `polygons.csv` as polygon info. * `image_negative_y` param for `createGiottoCosMxObject()` for toggling how images and polygons from mask images should be spatially mapped * `slide` param made more prominent in `createGiottoCosMxObject()` * docs
- import utility now supports vectors of filepaths when provided to `load_images()` and `load_polys()`
hotfix: cosmx convenience
fix: remove too restrictive filtering on scran results
fix: slide setting passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes:
createGiottoCosMxObject()not passingload_expression,load_cellmeta,load_transcriptsparams toimportCosMx()Enhancements
poly_prefparam forcreateGiottoCosMxObject()andimportCosMx()to select between loading the mask images or thepolygons.csvas polygon info.image_negative_yparam forcreateGiottoCosMxObject()for toggling how images and polygons from mask images should be spatially mappedslideparam made more prominent increateGiottoCosMxObject()