Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include file path in error message #7

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

crawford
Copy link
Contributor

@crawford crawford commented Aug 8, 2024

This is especially helpful when the file listed in the "extends" attribute cannot be read. Before this change, the path listed was the outermost tsconfig.json, which can be very confusing.

In order for this to work, an additional error type had to be created to distinguish between the two io:Error occurrences. This should also help to narrow down errors.

This is especially helpful when the file listed in the "extends"
attribute cannot be read. Before this change, the path listed was the
outermost tsconfig.json, which can be very confusing.

In order for this to work, an additional error type had to be created
to distinguish between the two io:Error occurrences. This should also
help to narrow down errors.
Copy link
Owner

@drivasperez drivasperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll merge and cut a new version.

@drivasperez drivasperez merged commit b1bb899 into drivasperez:master Aug 9, 2024
1 check passed
@crawford crawford deleted the error-path branch August 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants