Updates to S3Client internals to pass extras and more #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates a number of issues with S3Client internals, primarily the ability to pass
extra_args
that may be necessary to a user. This is primarily to address #254 and #180, which require passing extras around at the client level.The current implementation assumes that all of the upload/download/listing operations will always use the same extras at the level of a client. This is reasonable for most of the extra args except some of the upload ones (Metadata, ContentType, etc.). For the ContentType and ContentEncoding, we already provide a separate means of setting these per-file.
Additionally, we add documentation for RequestPayer explicitly and then ExtraArgs generally.
Bonus:
super().__init__
calls in the azure objects so that credential errors don't result in additional warnings about missing properties_s3_file_query
logic now that API changes make it simpler to tell if something is a file or dir immediatelyassert
in production code and status code checks that were too specificCloses #48
Closes #254
Closes #180
Closes #271
Closes #212