-
Notifications
You must be signed in to change notification settings - Fork 147
Added first draft of template for documentation of prediction algorithm #70
Added first draft of template for documentation of prediction algorithm #70
Conversation
@reubano Assigning to thee for review :) |
@tdraebing this is looking good! I didn't see a place to document the ML engine/backend, e.g., Keras/TensorFlow/etc. Where do you envision that information going? |
You are right. That should be a separate point. It would show up in the dependencies section, but that might not be easy and convenient to find for somebody reading the docs. |
Agreed! I think it's deserving of its own section (see the table in #18 for an example).
The aim is to support whatever model is thrown at it. Most implementations are based on Keras/Tensorflow, but that isn't a requirement. So as long the proper engines and libs are installed, everything should "just work".
If someone is more fluent in an engine than what was originally used, they are more than welcome to rewrite it. But I think this aspect is out-of-scope for the documentation. |
25cddf2
to
f1aa17b
Compare
Ok, I added an extra point for the ML framework into the "Prerequisites"-section. |
Thanks for the template! I have a small question: where is the difference between Prerequisites - is porting to Python 3.5 feasible? and Adaptation into Concept to Clinic - Comment on possible problems/solutions for porting the algorithm to Python 3.5+? Should the letter one contain more detailed steps / comments? |
Yes, the second one should contain detailed steps or comments. The point "Prerequisites - is porting to Python 3.5 feasible?" should be answered with yes/no. It was mainly put there in case the algorithm is not already written in any version of Python. Would that be the case anyway or rather out of scope? If we anyway only plan to use algorithms already implemented in Python, I would suggest removing this point. |
@WGierke and @tdraebing I think we can be fine limiting this to Python only. In this case, maybe change |
Nice! I think the free text box for the ML details would be better structured as a table. That way we can ensure to capture all of the information. I.e.:
those keys were just the first thing I came up with, so feel free to change them if there are other (more fitting) terms to use instead. |
f1aa17b
to
dd427bf
Compare
… to be included into the prediction module.
dd427bf
to
d529bfe
Compare
I removed the question of feasibility for now, since this might also be commented on in the section dealing with adapting the model to our needs. I also changed part of the dependency section into a table layout. |
Hey @reubano What do you think - is this ready to commit? |
LGTM |
Description
I added a first draft of a template for documenting candidates of prediction algorithms that could be included into this project.
Reference to official issue
Issue #58
Motivation and Context
The template contains the following sections:
How Has This Been Tested?
The markdown is displayed correctly in PyCharm.
This is just a first draft and I encourage everybody to comment or commit possible improvements to this pull request.
Screenshots (if appropriate):
CLA