Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Simplify the import in Readme #10

Open
jfthuong opened this issue May 30, 2023 · 2 comments
Open

[Suggestion] Simplify the import in Readme #10

jfthuong opened this issue May 30, 2023 · 2 comments

Comments

@jfthuong
Copy link

The Readme mentions that we should do:

from pandas_path import path

That might lead to some conflict if we use a variable path and we do some linting.

Why not documenting:

import pandas_path.path

?
@jfthuong jfthuong changed the title Simplify the import in Readme [Suggestion] Simplify the import in Readme May 30, 2023
@pjbull
Copy link
Member

pjbull commented May 31, 2023

Happy to merge a PR that adds that option to the README

jfthuong added a commit to jfthuong/pandas-path that referenced this issue Jun 1, 2023
@jfthuong
drivendataorg#10 Simplified import mechanism
e992fc4
@jfthuong
Copy link
Author

jfthuong commented Jun 1, 2023

PR done: #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jfthuong @pjbull