Don't resolve filepaths #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
AllenDowney
commented
Aug 24, 2022
ejm714
requested changes
Aug 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
======================================
Coverage 86.9% 87.0%
======================================
Files 29 29
Lines 1910 1919 +9
======================================
+ Hits 1661 1670 +9
Misses 249 249
|
ejm714
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
LGMT! @AllenDowney feel free to merge once the tests finish passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
data_dirgets resolved to an absolute path, which causes caching to fail.The fix is to leave it alone -- nothing wrong with relative paths.
Closes #218