-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get model_name from model class on loading checkpoint #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for silly-keller-664934 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ejm714
reviewed
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code all looks good, but can you look into the failing tests?
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
========================================
- Coverage 87.0% 86.8% -0.2%
========================================
Files 29 29
Lines 1919 1903 -16
========================================
- Hits 1670 1653 -17
- Misses 249 250 +1
|
ejm714
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #220, we add a
_default_model_name
property to each model class. This allows us to look up the config specifications for a loaded checkpoint based on the model class (not just the name). We also use a utility function withlru_cache
to make sure we don't have to load large checkpoint files more than once to get the hparams.Bonus fixes:
make format
command to run blacksave_dir
to the tests so that nothing gets written to local folders.DS_Store
files to test cleaningCloses #220