Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD model performance report #235

Merged
merged 18 commits into from
Sep 29, 2022
Merged

TD model performance report #235

merged 18 commits into from
Sep 29, 2022

Conversation

AllenDowney
Copy link
Contributor

@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for silly-keller-664934 ready!

Name Link
🔨 Latest commit 2cf26b8
🔍 Latest deploy log https://app.netlify.com/sites/silly-keller-664934/deploys/63359fb3d949aa0008e6ebc0
😎 Deploy Preview https://deploy-preview-235--silly-keller-664934.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AllenDowney
Copy link
Contributor Author

@ejm714 I'm pushing a first draft to test out the build process, make sure the paths to the images work, etc. If you want to have a first look at the content, please do. Or you can wait for a more polished version.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2022

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #235 (2cf26b8) into master (eba2cec) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #235     +/-   ##
========================================
- Coverage    87.2%   87.0%   -0.2%     
========================================
  Files          28      28             
  Lines        1961    1962      +1     
========================================
- Hits         1710    1707      -3     
- Misses        251     255      +4     
Impacted Files Coverage Δ
zamba/pytorch/transforms.py 79.2% <0.0%> (-5.7%) ⬇️
zamba/pytorch/dataloaders.py 91.2% <0.0%> (-1.8%) ⬇️
zamba/models/model_manager.py 84.3% <0.0%> (-0.5%) ⬇️
zamba/models/utils.py 100.0% <0.0%> (ø)
zamba/models/config.py 96.9% <0.0%> (+<0.1%) ⬆️

@AllenDowney
Copy link
Contributor Author

@glipstein The new page describing the performance of the time-dependent species model is at

https://deploy-preview-235--silly-keller-664934.netlify.app/models/td-full-metrics/

This is probably not where it will live in the site structure; I just put it there for now so we can preview it. Please take a look and let me know what you think.

@ejm714 Any thoughts about where this should go?

@ejm714 ejm714 requested a review from glipstein September 28, 2022 15:47
Copy link
Collaborator

@ejm714 ejm714 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple edits that you should be able to commit directly (with commit suggestion button) if you agree with them

docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
@ejm714
Copy link
Collaborator

ejm714 commented Sep 28, 2022

@ejm714 Any thoughts about where this should go?

I think it's in the right section, let's just move it below the Densepose entry and call it "African species performance"

@AllenDowney
Copy link
Contributor Author

@glipstein I took your suggestion about reordering sections and made some revisions to make the text flow. Please take another look and merge if you think it's done.

Copy link
Collaborator

@glipstein glipstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. I think the update looks great. Added a couple quick questions, otherwise all good on my end

docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
@AllenDowney
Copy link
Contributor Author

@ejm714 @glipstein One minor question: I put a hyphen in "time-distributed". Based on a quick search, the literature seems to be divided on this point. Any preference?

@ejm714
Copy link
Collaborator

ejm714 commented Sep 28, 2022

No strong preference on the hyphen, think it looks good with it.

I think this is looking really great @AllenDowney! The recall recall curve looks a little grainy to me -- maybe try exporting with a higher DPI? It might be useful to add a title as well so that's easier to skim the page and understand what the plot is showing.

@AllenDowney
Copy link
Contributor Author

@ejm714 Added a title and generated higher resolution figures -- that looks better!


## African forest model

The African species time-distributed model was trained using almost **250,000 videos from 14 countries** in West, Central, and East Africa.
Copy link
Collaborator

@ejm714 ejm714 Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason i had this as time_distributed was to mimic the models page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a reader of this page (or the models page) would understand why it's in code font.

docs/docs/models/td-full-metrics.md Outdated Show resolved Hide resolved
@ejm714
Copy link
Collaborator

ejm714 commented Sep 28, 2022

@AllenDowney don't worry about the tests, codecov is being flaky. once the last comments are addressed, we should be good to merge 🚀

Copy link
Collaborator

@glipstein glipstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllenDowney @ejm714 just confirming this isn't waiting on me to merge? Anything else you need me to do?

Excited to have this page!

@AllenDowney
Copy link
Contributor Author

@glipstein I was waiting for one last look and an approval. Now I will press the big green button.

@AllenDowney AllenDowney merged commit 5bbc33a into master Sep 29, 2022
@AllenDowney AllenDowney deleted the td-full-metric-docs branch September 29, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants