Update gate.js #19
Open
Update gate.js #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of requiring the control message to be the topic, I'm wondering if it could be more generic and changed to
message.control. That way, you can still preserve data that might be in the message topic as well as control the gate. I think would be a major breaking change though. Perhaps there is a way to listen for both? This is the first time I've ever done anything on github, so while I watched a few YouTube videos about it, please forgive me if I'm doing something terribly wrong. I wanted to try to test it myself, but I don't know how to create an updated npm package to import into NR.