Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented FindMembership method in organization service for gitea driver #263

Merged
merged 2 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion scm/driver/gitea/org.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ func (s *organizationService) Find(ctx context.Context, name string) (*scm.Organ
}

func (s *organizationService) FindMembership(ctx context.Context, name, username string) (*scm.Membership, *scm.Response, error) {
return nil, nil, scm.ErrNotSupported
membership := new(membership)
membership.Active = s.checkMembership(ctx, name, username)
out := new(permissions)
path := fmt.Sprintf("api/v1/users/%s/orgs/%s/permissions", username, name)
res, err := s.client.do(ctx, "GET", path, nil, out)
membership.Permissions = out
return convertMembership(membership), res, err
}

func (s *organizationService) List(ctx context.Context, opts scm.ListOptions) ([]*scm.Organization, *scm.Response, error) {
Expand All @@ -33,6 +39,18 @@ func (s *organizationService) List(ctx context.Context, opts scm.ListOptions) ([
return convertOrgList(out), res, err
}

type permissions struct {
IsOwner bool `json:"is_owner"`
IsAdmin bool `json:"is_admin"`
CanWrite bool `json:"can_write"`
CanRead bool `json:"can_read"`
CanCreateRepository bool `json:"can_create_repository"`
}
type membership struct {
Permissions *permissions
Active bool
}

//
// native data structures
//
Expand Down Expand Up @@ -60,3 +78,27 @@ func convertOrg(from *org) *scm.Organization {
Avatar: from.Avatar,
}
}

func (s *organizationService) checkMembership(ctx context.Context, name, username string) bool {
path := fmt.Sprintf("api/v1/orgs/%s/members/%s", name, username)
res, err := s.client.do(ctx, "GET", path, nil, nil)
if err != nil {
return false
}
return res.Status == 204
}

func convertMembership(from *membership) *scm.Membership {
to := new(scm.Membership)
to.Active = from.Active
isAdmin := from.Permissions.IsAdmin
isMember := from.Permissions.CanRead || from.Permissions.CanWrite || from.Permissions.CanCreateRepository
if isAdmin {
to.Role = scm.RoleAdmin
} else if isMember {
to.Role = scm.RoleMember
} else {
to.Role = scm.RoleUndefined
}
return to
}
27 changes: 24 additions & 3 deletions scm/driver/gitea/org_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,31 @@ func TestOrgFind(t *testing.T) {
}

func TestOrganizationFindMembership(t *testing.T) {
defer gock.Off()

gock.New("https://try.gitea.io").
Get("/api/v1/orgs/gogits/members/jcitizen").
Reply(204)

gock.New("https://try.gitea.io").
Get("/api/v1/users/jcitizen/orgs/gogits/permissions").
Reply(200).
Type("application/json").
File("testdata/permissions.json")

client, _ := New("https://try.gitea.io")
_, _, err := client.Organizations.FindMembership(context.Background(), "gogits", "jcitizen")
if err != scm.ErrNotSupported {
t.Errorf("Expect Not Supported error")
got, _, err := client.Organizations.FindMembership(context.Background(), "gogits", "jcitizen")
if err != nil {
t.Error(err)
}

want := new(scm.Membership)
raw, _ := ioutil.ReadFile("testdata/membership.json.golden")
json.Unmarshal(raw, &want)

if diff := cmp.Diff(got, want); diff != "" {
t.Errorf("Unexpected Results")
t.Log(diff)
}
}

Expand Down
4 changes: 4 additions & 0 deletions scm/driver/gitea/testdata/membership.json.golden
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"Active": true,
"Role": 2
}
7 changes: 7 additions & 0 deletions scm/driver/gitea/testdata/permissions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"is_owner": true,
"is_admin": true,
"can_write": true,
"can_read": true,
"can_create_repository": true
}