Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gitea tag link #52

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Fix gitea tag link #52

merged 2 commits into from
Jan 29, 2020

Conversation

lunny
Copy link
Contributor

@lunny lunny commented Jan 28, 2020

As title.

@claassistantio
Copy link

claassistantio commented Jan 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tboerger
tboerger approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of Gitea is required for that?

@lunny
Copy link
Contributor Author

lunny commented Jan 28, 2020 •
edited
Loading

I think since gitea v1.3.0, see go-gitea/gitea@513375c

@tboerger
Copy link
Contributor

But gitea had some fallback mechanism if this part have not been added to the URL? Because this had been working so far.

@jolheiser
Copy link

It looks like there was a redirect for "legacy" repositories in that commit, perhaps that worked for a while?
The code for redirecting "legacy" is still in master, but it has changed a little.

@lunny
Copy link
Contributor Author

lunny commented Jan 29, 2020

So it's now broken. See https://drone.gitea.com/gitea/go-sdk/254 .

@tboerger
Copy link
Contributor

So it's now broken. See https://drone.gitea.com/gitea/go-sdk/254 .

I can't see where something should be broken...

@lunny
Copy link
Contributor Author

lunny commented Jan 29, 2020

click the link on v0.11.0, you will get 404.

图片

@tboerger
Copy link
Contributor

You are right, I haven't realized that before. @bradrydzewski that fix should get into another release of Drone to fix the tag links for the Gitea integration.

@bradrydzewski bradrydzewski merged commit ee0770c into drone:master Jan 29, 2020
@lunny lunny deleted the lunny/fix_gitea_tag_link branch January 30, 2020 01:50
jstrachan pushed a commit to jstrachan/go-scm that referenced this pull request Dec 22, 2020
@jenkins-x-bot
Merge pull request drone#52 from jstrachan/stuff
b5128e0 
fix: add support for more webhooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tboerger tboerger tboerger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @claassistantio @tboerger @jolheiser @bradrydzewski