Fix issue with default string values being "\"\""
#389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, string-optionals will default to quotes wrapped in quotes:
Line 1053 takes in an empty value and returns
\"\"
tojava_value
, which already contains quotes around the string, causing optional values to pass a value of\"\"
for optional parameters, potentially causing upstream issues.Removing the
default_value
and passingfield.default
through tojava_value
resolves this issue and generates an empty string.d237d5c - This add the problematic line which returns empty quotes if the field default is empty.
#169 - This PR added a String format line which introduced the bug which formats quotes in additional quotes.
With a fix added, we see the generated code now properly generates an emtpy String value in
EchoArg
andEchoResult
.