-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android Sample App Consolidation and Kotlin Conversion #410
Android Sample App Consolidation and Kotlin Conversion #410
Conversation
…le application. Removing this as the code has been migrated into UserActivity.
e0efad2
to
892f417
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable to me.
Not a blocker, but I think the example could be easier for users to use if everything wasn't named Dropbox*
, since that makes it really hard to peruse and understand what is part of the Dropbox API and what's part of the example (i.e. DropboxApi
isn't actually part of the Dropbox SDK
😆 ). Perhaps making the sample app Sample
or something could help.
9f2aa69
to
45bb8fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thank you!
45bb8fe
to
7d1f750
Compare
7d1f750
to
21f0d76
Compare
Good call @rharter . I updated the naming to be clear. Also I moved all the |
It is confusing having two sample Android Applications. This is a step in the right direction to move everything to Kotlin and cleanup the codebase. There will still be more iterations that would make this ideal, but it's a good step forward.
Completed:
local.properties
method of setting theAPP_KEY
for the original sample app