Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec update action #413

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Fix spec update action #413

merged 3 commits into from
Feb 9, 2022

Conversation

sderickson
Copy link
Contributor

Not exactly sure how this worked before. But the last couple runs have been blocked by running on python 2, and running an npm install command that doesn't seem to do anything. This fixes the action, which successfully ran and was merged in #412.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does tox pass?
  • Do the tests pass?

@sderickson sderickson requested a review from rogebrd February 2, 2022 23:07
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #413 (f516544) into main (cc10efb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   64.24%   64.24%           
=======================================
  Files          30       30           
  Lines       51600    51600           
  Branches     5741     5741           
=======================================
  Hits        33150    33150           
  Misses      18292    18292           
  Partials      158      158           
Flag Coverage Δ
integration 64.15% <ø> (ø)
unit 63.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc10efb...f516544. Read the comment docs.

@rogebrd rogebrd merged commit 735e077 into main Feb 9, 2022
@rogebrd rogebrd deleted the remove-npm-install-and-package-lock branch February 9, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants