Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the name of generated rules to be valid in more cases #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattnathan
Copy link

In addition if you are outputting the generated files into a folder that
looks like the npm package name then omit the prefix part to simplify
importing in bazel.

For example if you npm package is @vue/cli and your output dir is
~/myrepo/vue/cli then the generated rule name will now be cli which
will allow importing like //myrepo/vue/cli. If the output dir doesn't
match the package name then any / will be replaced by '_' in the rule
name.

In addition if you are outputting the generated files into a folder that
looks like the npm package name then omit the prefix part to simplify
importing in bazel.

For example if you npm package is `@vue/cli` and your output dir is
`~/myrepo/vue/cli` then the generated rule name will now be `cli` which
will allow importing like `//myrepo/vue/cli`. If the output dir doesn't
match the package name then any `/` will be replaced by '_' in the rule
name.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants